pgsql: Don't leak memory during failure exit from SelectConfigFiles(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Don't leak memory during failure exit from SelectConfigFiles().
Date
Msg-id E1uma32-000XnQ-0N@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't leak memory during failure exit from SelectConfigFiles().

Make sure the memory allocated by make_absolute_path() is freed
when SelectConfigFiles() fails.  Since all the callers will exit
immediately in that case, there's no practical gain here, but
silencing Valgrind leak complaints seems useful.  In any case,
it was inconsistent that only one of the failure exits did this.

Author: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAJ7c6TMByXE8dc7zDvDWTQjk6o-XXAdRg_RAg5CBaUOgFPV3LQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ed0736172170bdae800b28e3555241b82854f09f

Modified Files
--------------
src/backend/utils/misc/guc.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix LSN format in debug message
Next
From: Álvaro Herrera
Date:
Subject: pgsql: Avoid including tableam.h and xlogreader.h in nbtree.h