pgsql: oauth: Remove stale events from the kqueue multiplexer - Mailing list pgsql-committers

From Jacob Champion
Subject pgsql: oauth: Remove stale events from the kqueue multiplexer
Date
Msg-id E1ukPct-001PKC-0t@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
oauth: Remove stale events from the kqueue multiplexer

If a socket is added to the kqueue, becomes readable/writable, and
subsequently becomes non-readable/writable again, the kqueue itself will
remain readable until either the socket registration is removed, or the
stale event is cleared via a call to kevent().

In many simple cases, Curl itself will remove the socket registration
quickly, but in real-world usage, this is not guaranteed to happen. The
kqueue can then remain stuck in a permanently readable state until the
request ends, which results in pointless wakeups for the client and
wasted CPU time.

Implement comb_multiplexer() to call kevent() and unstick any stale
events that would cause unnecessary callbacks. This is called right
after drive_request(), before we return control to the client to wait.

Suggested-by: Thomas Munro <thomas.munro@gmail.com>
Co-authored-by: Thomas Munro <thomas.munro@gmail.com>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Backpatch-through: 18
Discussion: https://postgr.es/m/CAOYmi+nDZxJHaWj9_jRSyf8uMToCADAmOfJEggsKW-kY7aUwHA@mail.gmail.com

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ff181d1f876f32da332238879c3834a3e7825a46

Modified Files
--------------
src/interfaces/libpq-oauth/oauth-curl.c | 67 ++++++++++++++++++++++++++++++---
1 file changed, 61 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Remove obsolete comment.
Next
From: Jacob Champion
Date:
Subject: Re: pgsql: oauth: Add unit tests for multiplexer handling