pgsql: Fix tab completion for ALTER ROLE|USER ... RESET - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Fix tab completion for ALTER ROLE|USER ... RESET
Date
Msg-id E1uhTv8-0001uS-2N@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix tab completion for ALTER ROLE|USER ... RESET

Commit c407d5426b87 added tab completion for ALTER ROLE|USER ... RESET,
with the intent to offer only the variables actually set on the role.
But as soon as the user started typing something, it would start to
offer all possible matching variables.

Fix this the same way ALTER DATABASE ... RESET does it, i.e. by
properly considering the prefix.

A second issue causing similar symptoms (offering variables that are not
actually set for a role) was caused by a match to another pattern. The
ALTER DATABASE ... RESET was already excluded, so do the same thing for
ROLE/USER.

Report and fix by Dagfinn Ilmari Mannsåker. Backpatch to 18, same as
c407d5426b87.

Author: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Reviewed-by: jian he <jian.universality@gmail.com>
Discussion: https://postgr.es/m/87qzyghw2x.fsf%40wibble.ilmari.org
Discussion: https://postgr.es/m/87tt4lumqz.fsf%40wibble.ilmari.org
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/88914332eaed702afb2cdbb0b776822738d58ece

Modified Files
--------------
src/bin/psql/tab-complete.in.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: Schema-qualify unnest() in ALTER DATABASE ... RESET
Next
From: Amit Kapila
Date:
Subject: pgsql: Fix a deadlock during ALTER SUBSCRIPTION ... DROP PUBLICATION.