pgsql: Remove unnecessary complication around xmlParseBalancedChunkMemo - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove unnecessary complication around xmlParseBalancedChunkMemo
Date
Msg-id E1ugnUc-001LBP-23@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove unnecessary complication around xmlParseBalancedChunkMemory.

When I prepared 71c0921b6 et al yesterday, I was thinking that the
logic involving explicitly freeing the node_list output was still
needed to dodge leakage bugs in libxml2.  But I was misremembering:
we introduced that only because with early 2.13.x releases we could
not trust xmlParseBalancedChunkMemory's result code, so we had to
look to see if a node list was returned or not.  There's no reason
to believe that xmlParseBalancedChunkMemory will fail to clean up
the node list when required, so simplify.  (This essentially
completes reverting all the non-cosmetic changes in 6082b3d5d.)

Reported-by: Jim Jones <jim.jones@uni-muenster.de>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/997668.1753802857@sss.pgh.pa.us
Backpatch-through: 13

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cdcdabce5b701ffd2e276214ac3cafddc21a72e2

Modified Files
--------------
src/backend/utils/adt/xml.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: Add commit 1d1612aec7 to .git-blame-ignore-revs.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Update comment