pgsql: Display Memoize planner estimates in EXPLAIN - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Display Memoize planner estimates in EXPLAIN
Date
Msg-id E1ugarA-001F32-2M@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Display Memoize planner estimates in EXPLAIN

There've been a few complaints that it can be overly difficult to figure
out why the planner picked a Memoize plan.  To help address that, here we
adjust the EXPLAIN output to display the following additional details:

1) The estimated number of cache entries that can be stored at once
2) The estimated number of unique lookup keys that we expect to see
3) The number of lookups we expect
4) The estimated hit ratio

Technically #4 can be calculated using #1, #2 and #3, but it's not a
particularly obvious calculation, so we opt to display it explicitly.
The original patch by Lukas Fittl only displayed the hit ratio, but
there was a fear that might lead to more questions about how that was
calculated.  The idea with displaying all 4 is to be transparent which
may allow queries to be tuned more easily.  For example, if #2 isn't
correct then maybe extended statistics or a manual n_distinct estimate can
be used to help fix poor plan choices.

Author: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Author: Lukas Fittl <lukas@fittl.com>
Reviewed-by: David Rowley <dgrowleyml@gmail.com>
Reviewed-by: Andrei Lepikhov <lepihov@gmail.com>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Discussion: https://postgr.es/m/CAP53Pky29GWAVVk3oBgKBDqhND0BRBN6yTPeguV_qSivFL5N_g%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4bc62b86849065939a6b85273fece6b92d6e97bf

Modified Files
--------------
src/backend/commands/explain.c          | 21 ++++++++++++++++++++-
src/backend/optimizer/path/costsize.c   | 18 ++++++++++++------
src/backend/optimizer/plan/createplan.c | 15 ++++++++++++---
src/backend/optimizer/util/pathnode.c   | 11 ++++++++---
src/include/nodes/pathnodes.h           |  4 +++-
src/include/nodes/plannodes.h           | 10 ++++++++++
src/include/optimizer/pathnode.h        |  2 +-
7 files changed, 66 insertions(+), 15 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Avoid regression in the size of XML input that we will accept.
Next
From: David Rowley
Date:
Subject: Re: pgsql: Remove misleading hint for "unexpected data beyond EOF" error.