pgsql: Remove misleading hint for "unexpected data beyond EOF" error. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Remove misleading hint for "unexpected data beyond EOF" error.
Date
Msg-id E1ugPbv-0019zf-2G@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Remove misleading hint for "unexpected data beyond EOF" error.
List pgsql-committers
Remove misleading hint for "unexpected data beyond EOF" error.

Commit ffae5cc5a6024b4e25ec920ed5c4dfac649605f8 added this hint in 2006,
but it's now obsolete and doesn't reflect what users should really check
in this situation. We were not able to agree on a new hint, so just delete
the existing one and update the comments to mention one possibility that
is known to cause problems of this kind: something other than PostgreSQL
is modifying files in the PostgreSQL data directory.

Author: Jakub Wartak <jakub.wartak@enterprisedb.com>
Reviewed-by: Robert Haas <rhaas@postgresql.org>
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Christoph Berg <myon@debian.org>
Discussion: https://postgr.es/m/CAKZiRmxNbcaL76x=09Sxf7aUmrRQJBf8drzDdUHo+j9_eM+VMg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d5b9b2d40262f57f58322ad49f8928fd4a492adb

Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Avoid throwing away the error message in syncrep_yyerror.
Next
From: Tom Lane
Date:
Subject: pgsql: Avoid regression in the size of XML input that we will accept.