pgsql: Clarify the ra != rb case in compareJsonbContainers(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Clarify the ra != rb case in compareJsonbContainers().
Date
Msg-id E1ubo1d-006TbO-1N@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Clarify the ra != rb case in compareJsonbContainers().

It's impossible to reach this case with either ra or rb being
WJB_DONE, because our earlier checks that the structure and
length of the inputs match should guarantee that we reach their
ends simultaneously.  However, the comment completely fails to
explain this, and the Asserts don't cover it either.  The comment
is pretty obscure anyway, so rewrite it, and extend the Asserts
to reject WJB_DONE.

This is only cosmetic, so no need for back-patch.

Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/0c623e8a204187b87b4736792398eaf1@postgrespro.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2a3a3964328a0b6b0cb278ae6cb595772586d654

Modified Files
--------------
src/backend/utils/adt/jsonb_util.c | 21 +++++++++------------
1 file changed, 9 insertions(+), 12 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Silence uninitialized-value warnings in compareJsonbContainers()
Next
From: Tom Lane
Date:
Subject: pgsql: Doc: clarify description of regexp fields in pg_ident.conf.