pgsql: pg_walsummary: Improve stability of test checking statistics - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: pg_walsummary: Improve stability of test checking statistics
Date
Msg-id E1uZ0Ga-005D5P-38@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_walsummary: Improve stability of test checking statistics

Per buildfarm member culicidae, the query checking for stats reported by
the WAL summarizer related to WAL reads is proving to be unstable.

Instead of a one-time query, this commit replaces the logic with a
polling query checking for the WAL read stats, making the test more
reliable on machines that could be slow with the stats reports.

This test has been introduced in f4694e0f35b2, so backpatch down to v18.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Reviewed-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/f35ba3db-fca7-4693-bc35-6db64488e4b1@gmail.com
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/330db576f8c37479d472c3e9b0eb6d47ba1d97f4

Modified Files
--------------
src/bin/pg_walsummary/t/002_blocks.pl | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Richard Guo
Date:
Subject: pgsql: Consider explicit incremental sort for Append and MergeAppend
Next
From: Tom Lane
Date:
Subject: pgsql: Fix low-probability memory leak in XMLSERIALIZE(... INDENT).