pgsql: Add CHECK_FOR_INTERRUPTS into pg_numa_query_pages - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Add CHECK_FOR_INTERRUPTS into pg_numa_query_pages
Date
Msg-id E1uWYiQ-004B7W-0o@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add CHECK_FOR_INTERRUPTS into pg_numa_query_pages

Querying the NUMA status can be quite time consuming, especially with
large shared buffers. 8cc139bec34a called numa_move_pages() once, for
all buffers, and we had to wait for the syscall to complete.

But with the chunking, introduced by 7fe2f67c7c to work around a kernel
bug, we can do CHECK_FOR_INTERRUPTS() after each chunk, allowing users
to abort the execution.

Reviewed-by: Christoph Berg <myon@debian.org>
Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://postgr.es/m/aEtDozLmtZddARdB@msg.df7cb.de
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/54ac4944c36f8f6cfc4deaa3f828118b564e1d3d

Modified Files
--------------
src/port/pg_numa.c | 3 +++
1 file changed, 3 insertions(+)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: Add CHECK_FOR_INTERRUPTS into pg_numa_query_pages
Next
From: Tomas Vondra
Date:
Subject: pgsql: Fix indentation in pg_numa code