pgsql: Make CREATE TABLE LIKE copy comments on NOT NULL constraints whe - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: Make CREATE TABLE LIKE copy comments on NOT NULL constraints whe
Date
Msg-id E1uUkkr-003QPm-12@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make CREATE TABLE LIKE copy comments on NOT NULL constraints when requested.

Commit 14e87ffa5c5 introduced support for adding comments to NOT NULL
constraints. However, CREATE TABLE LIKE INCLUDING COMMENTS did not copy
these comments to the new table. This was an oversight in that commit.

This commit corrects the behavior by ensuring CREATE TABLE LIKE to also copy
the comments on NOT NULL constraints when INCLUDING COMMENTS is specified.

Author: Jian He <jian.universality@gmail.com>
Co-authored-by: Álvaro Herrera <alvherre@kurilemu.de>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/127debef-e558-4784-9e24-0d5eaf91e2d1@oss.nttdata.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/81ce602d48e8b9cbc3c3a7d5b9d9ddbea7789c02

Modified Files
--------------
src/backend/parser/parse_utilcmd.c              | 22 ++++++++++++++++++
src/test/regress/expected/create_table_like.out | 30 +++++++++++++++++++++----
src/test/regress/sql/create_table_like.sql      | 16 +++++++++++--
3 files changed, 62 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Dean Rasheed
Date:
Subject: pgsql: doc: Fix indentation of MERGE synopsis.
Next
From: Álvaro Herrera
Date:
Subject: pgsql: Fix typo in comment