pgsql: Fix incorrect "return NULL" in BumpAllocLarge(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix incorrect "return NULL" in BumpAllocLarge().
Date
Msg-id E1uDuSw-0018th-23@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix incorrect "return NULL" in BumpAllocLarge().

This must be "return MemoryContextAllocationFailure(context, size, flags)"
instead.  The effect of this oversight is that if we got a malloc
failure right here, the code would act as though MCXT_ALLOC_NO_OOM
had been specified, whether it was or not.  That would likely lead
to a null-pointer-dereference crash at the unsuspecting call site.

Noted while messing with a patch to improve our Valgrind leak
detection support.  Back-patch to v17 where this code came in.

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a05cf22e0540e55fb34e26e6e98a8a76b76d1cbd

Modified Files
--------------
src/backend/utils/mmgr/bump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: pgsql: Remove GLOBALTABLESPACE_OID assert for locked buffers.
Next
From: Álvaro Herrera
Date:
Subject: pgsql: Sort includes in alphabetical order