pgsql: Maintain RelIdToTypeIdCacheHash in TypeCacheOpcCallback() - Mailing list pgsql-committers

From Alexander Korotkov
Subject pgsql: Maintain RelIdToTypeIdCacheHash in TypeCacheOpcCallback()
Date
Msg-id E1u7dsp-001RGh-1o@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Maintain RelIdToTypeIdCacheHash in TypeCacheOpcCallback()

b85a9d046efd introduced a new RelIdToTypeIdCacheHash, whose entries should
exist for typecache entries with TCFLAGS_HAVE_PG_TYPE_DATA flag set or any
of TCFLAGS_OPERATOR_FLAGS set or tupDesc set.  However, TypeCacheOpcCallback(),
which resets TCFLAGS_OPERATOR_FLAGS, was forgotten to update
RelIdToTypeIdCacheHash.

This commit adds a delete_rel_type_cache_if_needed() call to the
TypeCacheOpcCallback() function to maintain RelIdToTypeIdCacheHash after
resetting TCFLAGS_OPERATOR_FLAGS.

Also, this commit fixes the name of the delete_rel_type_cache_if_needed()
function in its mentions in the comments.

Reported-by: Noah Misch
Discussion: https://postgr.es/m/20250411203241.e9.nmisch%40google.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bb78e4267817b5c1f5a8ff5b0b93fe756e514bb0

Modified Files
--------------
src/backend/utils/cache/typcache.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Change the names generated for child foreign key constraints.
Next
From: Jacob Champion
Date:
Subject: pgsql: oauth: Support Python 3.6 in tests