pgsql: Fix pg_dump --clean with partitioned indexes. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix pg_dump --clean with partitioned indexes.
Date
Msg-id E1u56cL-000MMa-0C@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix pg_dump --clean with partitioned indexes.

We'd try to drop the partitions of a partitioned index separately,
which is disallowed by the backend, leading to an error during
restore.  While the error is harmless, it causes problems if you
try to use --single-transaction mode.

Fortunately, there seems no need to do a DROP at all, since the
partition will go away silently when we drop either the parent index
or the partition's table.  So just make the DROP conditional on not
being a partition.

Reported-by: jian he <jian.universality@gmail.com>
Author: jian he <jian.universality@gmail.com>
Reviewed-by: Pavel Stehule <pavel.stehule@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CACJufxF0QSdkjFKF4di-JGWN6CSdQYEAhGPmQJJCdkSZtd=oLg@mail.gmail.com
Backpatch-through: 13

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6a3e57865fc0123d76b998492093fcb9649b35b2

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 26 ++++++++++++++++++++------
1 file changed, 20 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: pgsql: Add support for basic NUMA awareness
Next
From: Tomas Vondra
Date:
Subject: Re: pgsql: Add support for basic NUMA awareness