pgsql: Stabilize 035_standby_logical_decoding.pl. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Stabilize 035_standby_logical_decoding.pl.
Date
Msg-id E1u20UW-003Edy-1R@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Stabilize 035_standby_logical_decoding.pl.

Some tests try to invalidate logical slots on the standby server by
running VACUUM on the primary. The problem is that xl_running_xacts was
getting generated and replayed before the VACUUM command, leading to the
advancement of the active slot's catalog_xmin. Due to this, active slots
were not getting invalidated, leading to test failures.

We fix it by skipping the generation of xl_running_xacts for the required
tests with the help of injection points. As the required interface for
injection points was not present in back branches, we fixed the failing
tests in them by disallowing the slot to become active for the required
cases (where rows_removed conflict could be generated).

Author: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 16, where it was introduced
Discussion: https://postgr.es/m/Z6oQXc8LmiTLfwLA@ip-10-97-1-34.eu-west-3.compute.internal

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/86392e8827d874dd2adc4393ce7a962513620455

Modified Files
--------------
.../recovery/t/035_standby_logical_decoding.pl     | 49 +++++++++++++---------
1 file changed, 29 insertions(+), 20 deletions(-)


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: Fix PG 17 [NOT] NULL optimization bug for domains
Next
From: David Rowley
Date:
Subject: Re: pgsql: Transfer statistics during pg_upgrade.