pgsql: Remove XLogFileInit() ability to skip ControlFileLock. - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Remove XLogFileInit() ability to skip ControlFileLock.
Date
Msg-id E1u1Ida-002umL-1C@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove XLogFileInit() ability to skip ControlFileLock.

Cold paths, initdb and end-of-recovery, used it.  Don't optimize them.

This commit has been applied as of c53c6b98d38a in v15 and newer
versions.  This is required on stable branches of v13 and v14 to fix a
regression reported by Noah Misch, introduced by 1f95181b44c8, causing
spurious failures in archive recovery (neither streaming nor archive
recovery) with concurrent restartpoints.  The backpatched versions of
the patches have been aligned on these branches by me, Noah Misch is the
author.  Tests have been conducted by the both of us.

Reported-by: Arun Thirupathi
Author: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com
Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com
Backpatch-through: 13

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/df8ec9634ccdc3c67871e36fcc54c44370639b37
Author: Noah Misch <noah@leadboat.com>

Modified Files
--------------
src/backend/access/transam/xlog.c     | 46 +++++++++++------------------------
src/backend/replication/walreceiver.c |  2 +-
src/include/access/xlog.h             |  2 +-
3 files changed, 16 insertions(+), 34 deletions(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: Quote filename in error message
Next
From: Michael Paquier
Date:
Subject: pgsql: In XLogFileInit(), fix *use_existent postcondition to suit calle