pgsql: Skip second WriteToc() call for custom-format dumps without data - Mailing list pgsql-committers

From Nathan Bossart
Subject pgsql: Skip second WriteToc() call for custom-format dumps without data
Date
Msg-id E1u0n52-002gUH-2G@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Skip second WriteToc() call for custom-format dumps without data.

Presently, "pg_dump --format=custom" calls WriteToc() twice.  The
second call updates the data offset information, which allegedly
makes parallel pg_restore significantly faster.  However, if we're
not dumping any data, there are no data offsets to update, so we
can skip this step.

Reviewed-by: Jeff Davis <pgsql@j-davis.com>
Discussion: https://postgr.es/m/Z9c1rbzZegYQTOQE%40nathan

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e3cc039a7d930ffe86e706944a2b3368bd3ef506

Modified Files
--------------
src/bin/pg_dump/pg_backup_custom.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Melanie Plageman
Date:
Subject: pgsql: Remove superfluous autoprewarm check
Next
From: Nathan Bossart
Date:
Subject: pgsql: Remove unused function parameters in pg_backup_archiver.c.