pgsql: Move RemoveInheritedConstraint() call slightly earlier - Mailing list pgsql-committers

From Peter Eisentraut
Subject pgsql: Move RemoveInheritedConstraint() call slightly earlier
Date
Msg-id E1trwEb-001uNB-36@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Move RemoveInheritedConstraint() call slightly earlier

This change is harmless and does not affect the existing intended
operation.  It is necessary for a subsequent patch operation (NOT
ENFORCED foreign keys), where we may need to change the child
constraint to enforced.  In this case, we would create the necessary
triggers and queue the constraint for validation, so it is important
to remove any unnecessary constraints before proceeding.

This is a small change that could have been included in the previous
"split tryAttachPartitionForeignKey" refactoring patch (commit
1d26c2d2c4b), but was kept separate to highlight the changes.

Author: Amul Sul <amul.sul@enterprisedb.com>
Reviewed-by: Alexandra Wang <alexandra.wang.oss@gmail.com>
Discussion:
https://www.postgresql.org/message-id/flat/CAAJ_b962c5AcYW9KUt_R_ER5qs3fUGbe4az-SP-vuwPS-w-AGA%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dabccf45139a8c7c3c2e7683a943c31077e55a78

Modified Files
--------------
src/backend/commands/tablecmds.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)


pgsql-committers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: pgsql: refactor: re-add ATExecAlterChildConstr()
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: Add special case fast-paths for strict functions