pgsql: Silence warning in older versions of Valgrind - Mailing list pgsql-committers

From John Naylor
Subject pgsql: Silence warning in older versions of Valgrind
Date
Msg-id E1tmWIl-000Rad-1x@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Silence warning in older versions of Valgrind

Due to misunderstanding on my part, commit 235328ee4 did not go far
enough to silence older versions of Valgrind. For those, it was the bit
scan that was problematic, not the subsequent bit-masking operation. To
fix, use the unaligned path for the trailing bytes. Since we don't have
a bit scan here anymore, also remove some comments and endian-specific
coding around that.

Reported-by: Anton A. Melnikov <a.melnikov@postgrespro.ru>
Discussion: https://postgr.es/m/f3aa2d45-3b28-41c5-9499-a1bc30e0f8ec@postgrespro.ru
Backpatch-through: 17

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fde7c0164ea20433964a0a05a91c5708384a285c

Modified Files
--------------
src/include/common/hashfn_unstable.h | 26 +++-----------------------
1 file changed, 3 insertions(+), 23 deletions(-)


pgsql-committers by date:

Previous
From: John Naylor
Date:
Subject: pgsql: Silence warning in older versions of Valgrind
Next
From: Andres Freund
Date:
Subject: pgsql: Add static asserts for MAX_BACKENDS limiting factors