pgsql: backport: Extend background_psql() to be able to start asynchron - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: backport: Extend background_psql() to be able to start asynchron
Date
Msg-id E1tkmBi-0009gA-2k@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
backport: Extend background_psql() to be able to start asynchronously

This is a backport of ba08edb0654. Originally it was only applied to master,
but I (Andres) am planning to fix a few bugs in BackgroundPsql, which would be
somewhat harder with the behavioural differences across branches. It's also
generally good for test infrastructure to behave similarly across branches, to
avoid pain during backpatching.

Discussion: https://postgr.es/m/ilcctzb5ju2gulvnadjmhgatnkxsdpac652byb2u3d3wqziyvx@fbuqcglker46

Michael's original commit message:

This commit extends the constructor routine of BackgroundPsql.pm with a
new "wait" parameter.  If set to 0, the routine returns without waiting
for psql to start, ready to consume input.

background_psql() in Cluster.pm gains the same "wait" parameter.  The
default behavior is still to wait for psql to start.  It becomes now
possible to not wait, giving to TAP scripts the possibility to perform
actions between a BackgroundPsql startup and its wait_connect() call.

Author: Jacob Champion
Discussion: https://postgr.es/m/CAOYmi+=60deN20WDyCoHCiecgivJxr=98s7s7-C8SkXwrCfHXg@mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6af51bf05a6afd8e10ef53c1c87de3906e2532a9

Modified Files
--------------
src/test/perl/PostgreSQL/Test/BackgroundPsql.pm | 28 ++++++++++++++++++-------
src/test/perl/PostgresNode.pm                   | 10 ++++++++-
2 files changed, 30 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: Álvaro Herrera
Date:
Subject: pgsql: Add ATAlterConstraint struct for ALTER .. CONSTRAINT
Next
From: Andres Freund
Date:
Subject: pgsql: tests: BackgroundPsql: Fix potential for lost errors on windows