pgsql: Fix issue in recovery test 041_checkpoint_at_promote - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Fix issue in recovery test 041_checkpoint_at_promote
Date
Msg-id E1ti8Zy-006i3p-Tt@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix issue in recovery test 041_checkpoint_at_promote

The phase of the test waiting for a restartpoint to complete was not
working as intended, due to a log_contains() call incorrectly
written.

The problem reported by the author could be simply reproduced by
removing the injection_points_wakeup() call: the test succeeds rather
than waiting for the restartpoint completion.  In most cases, the
restartpoint completion is fast enough that the test offered the wanted
coverage.  On slow machines, it could have become unreliable.

Oversight in 6782709df81f.

Author: Nitin Jadhav
Discussion: https://postgr.es/m/CAMm1aWa_6u+o52r7h7G6pX-oWD0Qraf0ee17Ma50qxGS0B_Rzg@mail.gmail.com
Backpatch-through: 17

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3dea7af519fd2b6e098c4261cb91d318cf31a8d4

Modified Files
--------------
src/test/recovery/t/041_checkpoint_at_promote.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix some inconsistencies with memory freeing in pg_createsubscri
Next
From: Andres Freund
Date:
Subject: pgsql: meson: Fix failure to detect bsd_auth.h presence