pgsql: Improve TAP tests of pg_basebackup - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Improve TAP tests of pg_basebackup
Date
Msg-id E1taqWI-0032Zq-V4@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve TAP tests of pg_basebackup

This addresses some minor issues with the TAP tests of pg_basebackup:
- Remove three duplicated tests used for incorrect option combinations.
- Add more pattern checks for commands doomed to fail, to make sure that
the error generated is the expected one.  These are for tests related to
the tablespace mapping and incorrect option combinations.
- Fix the description of one test for the case of backup target versus
format.

Issues noticed while reviewing this area of the tests.

Discussion: https://postgr.es/m/87bjvy50cs.fsf@wibble.ilmari.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/858b4db378f2ba1dacd078b3b052027c3518fd13

Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 59 ++++++++++------------------
1 file changed, 21 insertions(+), 38 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Support RN (roman-numeral format) in to_number().
Next
From: Michael Paquier
Date:
Subject: pgsql: Add error pattern checks for some TAP tests for non-existing obj