pgsql: Fix setrefs.c's failure to do expression processing on prune ste - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix setrefs.c's failure to do expression processing on prune ste
Date
Msg-id E1tYbLW-0020CM-1G@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix setrefs.c's failure to do expression processing on prune steps.

We should run the expression subtrees of PartitionedRelPruneInfo
structs through fix_scan_expr.  Failure to do so means that
AlternativeSubPlans within those expressions won't be cleaned up
properly, resulting in "unrecognized node type" errors since v14.

It seems fairly likely that at least some of the other steps done
by fix_scan_expr are important here as well, resulting in as-yet-
undetected bugs.  Therefore, I've chosen to back-patch this to
all supported branches including v13, even though the known
symptom doesn't manifest in v13.

Per bug #18778 from Alexander Lakhin.

Discussion: https://postgr.es/m/18778-24cd399df6c806af@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bf826ea062979da02395fb2e8961feeef47604da

Modified Files
--------------
src/backend/optimizer/plan/setrefs.c          | 12 +++++++++++
src/test/regress/expected/partition_prune.out | 29 +++++++++++++++++++++++++++
src/test/regress/sql/partition_prune.sql      | 15 ++++++++++++++
3 files changed, 56 insertions(+)


pgsql-committers by date:

Previous
From: Melanie Plageman
Date:
Subject: pgsql: Add and use BitmapHeapScanDescData struct
Next
From: Nathan Bossart
Date:
Subject: pgsql: Remove redefinitions of SIG_* macros in win32_port.h.