pgsql: Fix an ALTER GROUP ... DROP USER error message. - Mailing list pgsql-committers

From Nathan Bossart
Subject pgsql: Fix an ALTER GROUP ... DROP USER error message.
Date
Msg-id E1tW1iW-000jfC-0w@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix an ALTER GROUP ... DROP USER error message.

This error message stated the privileges required to add a member
to a group even if the user was trying to drop a member:

        postgres=> alter group a drop user b;
        ERROR:  permission denied to alter role
        DETAIL:  Only roles with the ADMIN option on role "a" may add members.

Since the required privileges for both operations are the same, we
can fix this by modifying the message to mention both adding and
dropping members:

        postgres=> alter group a drop user b;
        ERROR:  permission denied to alter role
        DETAIL:  Only roles with the ADMIN option on role "a" may add or drop members.

Author: ChangAo Chen
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/tencent_FAA0D00E3514AAF0BBB6322542A6094FEF05%40qq.com
Backpatch-through: 16

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/39e3bcae44868734504c3decbb6708c36a5a84b2

Modified Files
--------------
src/backend/commands/user.c              | 4 ++--
src/test/regress/expected/privileges.out | 7 +++++++
src/test/regress/sql/privileges.sql      | 3 +++
3 files changed, 12 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Use @extschema:name@ notation in contrib transform modules.
Next
From: Michael Paquier
Date:
Subject: pgsql: Refactor some code related to backend statistics