pgsql: Fix off_t overflow in pg_basebackup on Windows. - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Fix off_t overflow in pg_basebackup on Windows.
Date
Msg-id E1tVisF-000asa-5W@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix off_t overflow in pg_basebackup on Windows.

walmethods.c used off_t to navigate around a pg_wal.tar file that could
exceed 2GB, which doesn't work on Windows and would fail with misleading
errors.  Use pgoff_t instead.

Back-patch to all supported branches.

Author: Davinder Singh <davinder.singh@enterprisedb.com>
Reported-by: Jakub Wartak <jakub.wartak@enterprisedb.com>
Discussion: https://postgr.es/m/CAKZiRmyM4YnokK6Oenw5JKwAQ3rhP0YTz2T-tiw5dAQjGRXE3Q%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/970b97eeb8f036e534abe183fd41604671f7674d

Modified Files
--------------
src/bin/pg_basebackup/receivelog.c | 2 +-
src/bin/pg_basebackup/walmethods.c | 2 +-
src/bin/pg_basebackup/walmethods.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Provide 64-bit ftruncate() and lseek() on Windows.
Next
From: Thomas Munro
Date:
Subject: pgsql: Fix off_t overflow in pg_basebackup on Windows.