pgsql: pg_combinebackup: Fix PITR comparison test in 002_compare_backup - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: pg_combinebackup: Fix PITR comparison test in 002_compare_backup
Date
Msg-id E1tNLOV-0035PB-H3@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
pg_combinebackup: Fix PITR comparison test in 002_compare_backups

The test was creating both the dumps to compare from the same database
on the same node, so it would never detect any mismatches when comparing
the logical dumps of the two servers.

Fixing this issue has revealed that there is a difference in the dumps:
the tablespaces paths are different.  This commit uses compare_text()
with a custom comparison function to erase the difference (slightly
tweaked to be able to work with WIN32 and non-WIN32 paths).  This way,
the non-relevant parts of the tablespace path are ignored from the check
with the basic structure of the query string still compared.

Author: Dagfinn Ilmari Mannsåker
Discussion: https://postgr.es/m/87h67653ns.fsf@wibble.ilmari.org
Backpatch-through: 17

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/94e7e77a95ba501955788e1e124b577a665cd85d

Modified Files
--------------
src/bin/pg_combinebackup/t/002_compare_backups.pl | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: doc: Mention BRIN indexes support parallel builds
Next
From: Michael Paquier
Date:
Subject: pgsql: Print out error position for some more DDLs