pgsql: Fix warnings about declaration of environ on MinGW. - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Fix warnings about declaration of environ on MinGW.
Date
Msg-id E1tMQRz-002g4i-Cv@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix warnings about declaration of environ on MinGW.

POSIX says that the global variable environ shouldn't be declared in a
header, and that you have to declare it yourself.  MinGW declares it in
<stdlib.h> with some macrology that messes up our declarations.  Visual
Studio doesn't warn (there are clues that it may also declare it, but if
so, apparently compatibly).  Suppress our declarations, on MinGW only.

This clears the last warnings on CI's optional MinGW task, and hopefully
on build farm animal fairywren too.

Like 1319997d, no back-patch for now as it's not known to be breaking
anything, and my humble goal is just to keep the MinGW build clean going
forward.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> (earlier version)
Discussion: https://postgr.es/m/CA%2BhUKGJLMh%2B6W5E4M_jSFb43gnrA_-Q6-%2BBf3HkBXyGfRFcBsQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7bc9a8bdd2d6f6da664572456f226c54e9c9e3dd

Modified Files
--------------
src/backend/postmaster/postmaster.c | 2 ++
src/backend/utils/misc/ps_status.c  | 2 ++
src/test/regress/regress.c          | 2 ++
3 files changed, 6 insertions(+)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Remove EXTENSION_DONT_CHECK_SIZE from md.c.
Next
From: Álvaro Herrera
Date:
Subject: pgsql: Refactor some SQL/JSON error messages