pgsql: Improve error message for replication of generated columns. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Improve error message for replication of generated columns.
Date
Msg-id E1tG95N-003hgd-Pc@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve error message for replication of generated columns.

Currently, logical replication produces a generic error message when
targeting a subscriber-side table column that is either missing or
generated. The error message can be misleading for generated columns.

This patch introduces a specific error message to clarify the issue when
generated columns are involved.

Author: Shubham Khanna
Reviewed-by: Peter Smith, Vignesh C, Amit Kapila
Discussion: https://postgr.es/m/CAHv8RjJBvYtqU7OAofBizOmQOK2Q8h+w9v2_cQWxT_gO7er3Aw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8fcd80258bcf43dab93d877a5de0ce3f4d2bd471

Modified Files
--------------
src/backend/replication/logical/relation.c | 91 ++++++++++++++++++++----------
src/test/subscription/t/011_generated.pl   | 42 ++++++++++++++
2 files changed, 103 insertions(+), 30 deletions(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: If a C23 compiler is detected, try asking for C17.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Support LIKE with nondeterministic collations