pgsql: Check for STATUS_DELETE_PENDING on Windows. - Mailing list pgsql-committers

From Andrew Dunstan
Subject pgsql: Check for STATUS_DELETE_PENDING on Windows.
Date
Msg-id E1t9Bms-000hQ8-KL@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Check for STATUS_DELETE_PENDING on Windows.

1.  Update our open() wrapper to check for NT's STATUS_DELETE_PENDING
and translate it to Unix-like errors.  This is done with
RtlGetLastNtStatus(), which is dynamically loaded from ntdll.  A new
file win32ntdll.c centralizes lookup of NT functions, in case we decide
to add more in the future.

2.  Remove non-working code that was trying to do something similar for
stat(), and just reuse the open() wrapper code.  As a side effect,
stat() also gains resilience against "sharing violation" errors.

3.  Since stat() is used very early in process startup, remove the
requirement that the Win32 signal event has been created before
pgwin32_open_handle() is reached.  Instead, teach pg_usleep() to fall
back to a non-interruptible sleep if reached before the signal event is
available.

This could be back-patched, but for now it's in master only.  The
problem has apparently been with us for a long time and generated only a
few complaints.  Proposed patches trigger it more often, which led to
this investigation and fix.

Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Alexander Lakhin <exclusion@gmail.com>
Reviewed-by: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Discussion: https://postgr.es/m/CA%2BhUKGJz_pZTF9mckn6XgSv69%2BjGwdgLkxZ6b3NWGLBCVjqUZA%40mail.gmail.com
(cherry picked from commit e2f0f8ed251d02c1eda79e1ca3cb3db2681e7a86)

Author: Thomas Munro <tmunro@postgresql.org>
Author: Alexandra Wang <alexandra.wang.oss@gmail.com>

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1bf47d89776c2647d896f308687fa13d6c2877e2
Author: Thomas Munro <tmunro@postgresql.org>

Modified Files
--------------
configure                       |   6 ++
configure.ac                    |   1 +
src/backend/port/win32/signal.c |  12 ++-
src/include/port.h              |   1 +
src/include/port/win32ntdll.h   |  27 +++++++
src/port/open.c                 | 104 ++++++++++++++------------
src/port/win32ntdll.c           |  69 +++++++++++++++++
src/port/win32stat.c            | 159 ++--------------------------------------
src/tools/msvc/Mkvcbuild.pm     |   2 +-
9 files changed, 177 insertions(+), 204 deletions(-)


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Provide lstat() for Windows.
Next
From: Richard Guo
Date:
Subject: pgsql: Fix inconsistent RestrictInfo serial numbers