pgsql: vacuumdb: Skip temporary tables in query to build list of relati - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: vacuumdb: Skip temporary tables in query to build list of relati
Date
Msg-id E1stKqI-000nGy-7d@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
vacuumdb: Skip temporary tables in query to build list of relations

Running vacuumdb with a non-superuser while another user has created a
temporary table would lead to a mid-flight permission failure,
interrupting the operation.  vacuum_rel() skips temporary relations of
other backends, and it makes no sense for vacuumdb to know about these
relations, so let's switch it to ignore temporary relations entirely.

Adding a qual in the query based on relpersistence simplifies the
generation of its WHERE clause in vacuum_one_database(), per se the
removal of "has_where".

Author: VaibhaveS, Michael Paquier
Reviewed-by: Fujii Masao
Discussion: https://postgr.es/m/CAM_eQjwfAR=y3G1fGyS1U9FTmc+FyJm9amNfY2QCZBnDDbNPZg@mail.gmail.com
Backpatch-through: 12

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/60c618216ddbfcd65fc6c8078c1dbb775643662b

Modified Files
--------------
src/bin/scripts/vacuumdb.c | 26 ++++++++++++++++----------
1 file changed, 16 insertions(+), 10 deletions(-)


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Doc: Add the steps for upgrading the logical replication cluster
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Turn 'if' condition around to avoid Svace complaint