pgsql: Cache typarray for fast lookups in binary upgrade mode - Mailing list pgsql-committers

From Daniel Gustafsson
Subject pgsql: Cache typarray for fast lookups in binary upgrade mode
Date
Msg-id E1sl2i1-000En2-LR@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Cache typarray for fast lookups in binary upgrade mode

When upgrading a large schema it adds significant overhead to perform
individual catalog lookups per relation in order to retrieve Oid for
preserving Oid calls. This instead adds the typarray to the TypeInfo
cache which then allows for fast lookups using the existing API. A
35% reduction of pg_dump runtime in binary upgrade mode was observed
with this change.

Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Discussion: https://postgr.es/m/8F1F1E1D-D17B-4B33-B014-EDBCD15F3F0B@yesql.se

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6ebeeae29626e742bbe16db3fa6fccf1186c0dfb

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 20 ++++++++------------
src/bin/pg_dump/pg_dump.h |  1 +
2 files changed, 9 insertions(+), 12 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: More use of getpwuid_r() directly
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Translation updates