pgsql: Explain dropdb can't use syscache because of TOAST - Mailing list pgsql-committers

From Tomas Vondra
Subject pgsql: Explain dropdb can't use syscache because of TOAST
Date
Msg-id E1sg14w-000QHV-Ha@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Explain dropdb can't use syscache because of TOAST

Add a comment explaining dropdb() can't rely on syscache. The issue with
flattened rows was fixed by commit 0f92b230f88b, but better to have
a clear explanation why the systable scan is necessary. The other places
doing in-place updates on pg_database have the same comment.

Suggestion and patch by Yugo Nagata. Backpatch to 12, same as the fix.

Author: Yugo Nagata
Backpatch-through: 12
Discussion: https://postgr.es/m/CAJTYsWWNkCt+-UnMhg=BiCD3Mh8c2JdHLofPxsW3m2dkDFw8RA@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9d42627bcaffb34d4c165a4618583a81db67c48d

Modified Files
--------------
src/backend/commands/dbcommands.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tomas Vondra
Date:
Subject: pgsql: Explain dropdb can't use syscache because of TOAST
Next
From: Tomas Vondra
Date:
Subject: pgsql: Mark search_path as GUC_REPORT