pgsql: Initialize HASHCTL differently, to suppress Coverity warning - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Initialize HASHCTL differently, to suppress Coverity warning
Date
Msg-id E1sdCGe-003jcV-Fm@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Initialize HASHCTL differently, to suppress Coverity warning
List pgsql-committers
Initialize HASHCTL differently, to suppress Coverity warning

Coverity complained that the hash_create() call might access
hash_table_ctl->hctl. That's a false alarm, hash_create() only
accesses that field when passed the HASH_SHARED_MEM flag. Try to
silence it by using a plain local variable instead of a const. That's
how the HASHCTL is initialized in all the other hash_create() calls.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f011e82c2c886329245f821146c560a3607f7aba

Modified Files
--------------
src/backend/access/transam/xlogprefetcher.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Suppress Coverity warnings about Asserts in get_name_for_var_fie
Next
From: Peter Geoghegan
Date:
Subject: pgsql: Avoid unneeded nbtree backwards scan buffer locks.