pgsql: Restrict accesses to non-system views and foreign tables during - Mailing list pgsql-committers

From Masahiko Sawada
Subject pgsql: Restrict accesses to non-system views and foreign tables during
Date
Msg-id E1saxQa-002nCS-28@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Restrict accesses to non-system views and foreign tables during pg_dump.

When pg_dump retrieves the list of database objects and performs the
data dump, there was possibility that objects are replaced with others
of the same name, such as views, and access them. This vulnerability
could result in code execution with superuser privileges during the
pg_dump process.

This issue can arise when dumping data of sequences, foreign
tables (only 13 or later), or tables registered with a WHERE clause in
the extension configuration table.

To address this, pg_dump now utilizes the newly introduced
restrict_nonsystem_relation_kind GUC parameter to restrict the
accesses to non-system views and foreign tables during the dump
process. This new GUC parameter is added to back branches too, but
these changes do not require cluster recreation.

Back-patch to all supported branches.

Reviewed-by: Noah Misch
Security: CVE-2024-7348
Backpatch-through: 12

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bbc94abf66407ebfe14d186812674896f85375d9

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out |  9 ++++
contrib/postgres_fdw/sql/postgres_fdw.sql      |  7 +++
doc/src/sgml/config.sgml                       | 17 +++++++
doc/src/sgml/ref/pg_dump.sgml                  |  8 ++++
src/backend/foreign/foreign.c                  | 10 ++++
src/backend/optimizer/plan/createplan.c        | 13 ++++++
src/backend/optimizer/util/plancat.c           | 12 +++++
src/backend/rewrite/rewriteHandler.c           | 17 +++++++
src/backend/tcop/postgres.c                    | 63 ++++++++++++++++++++++++++
src/backend/utils/misc/guc.c                   | 12 +++++
src/bin/pg_dump/pg_dump.c                      | 47 +++++++++++++++++++
src/include/tcop/tcopprot.h                    |  9 ++++
src/test/regress/expected/create_view.out      | 19 +++++++-
src/test/regress/sql/create_view.sql           |  8 ++++
14 files changed, 250 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Masahiko Sawada
Date:
Subject: pgsql: Restrict accesses to non-system views and foreign tables during
Next
From: Masahiko Sawada
Date:
Subject: pgsql: Restrict accesses to non-system views and foreign tables during