pgsql: Add more debugging information when dropping twice pgstats entry - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Add more debugging information when dropping twice pgstats entry
Date
Msg-id E1sFWBf-000OI0-1v@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add more debugging information when dropping twice pgstats entry

Floris Van Nee has reported a bug in the pgstats facility where a stats
entry already dropped would get again dropped.  This case should not
happen, still the error generated did not offer any details about the
stats entry getting dropped.

This commit improves the error message generated to inform about the
stats entry kind, database OID, object OID and refcount, which should
help to debug more the problem reported.  Bertrand Drouvot has been
independently able to reach this error path while writing a new feature,
and more details about the failure would have been helpful for
debugging.

Author: Andres Freund, Bertrand Drouvot
Discussion: https://postgr.es/m/20240505160915.6boysum4f34siqct@awork3.anarazel.de
Discussion: https://postgr.es/m/ZkM30paAD8Cr/Bix@ip-10-97-1-34.eu-west-3.compute.internal
Backpatch-through: 15

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d92573adcb02564439086d1c257d7821606a3115

Modified Files
--------------
src/backend/utils/activity/pgstat_shmem.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Etsuro Fujita
Date:
Subject: pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser
Next
From: Tom Lane
Date:
Subject: pgsql: Fix behavior of stable functions called from a CALL's argument l