pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser - Mailing list pgsql-committers

From Etsuro Fujita
Subject pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser
Date
Msg-id E1sFVNk-000Nvb-92@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote servers.

Previously, when considering LIMIT pushdown, postgres_fdw failed to
check whether the query has this clause, which led to pushing false
LIMIT clauses, causing incorrect results.

This clause has been supported since v13, so we need to do a
remote-version check before deciding that it will be safe to push such a
clause, but we do not currently have a way to do the check (without
accessing the remote server); disable pushing such a clause for now.

Oversight in commit 357889eb1.  Back-patch to v13, where that commit
added the support.

Per bug #18467 from Onder Kalaci.

Patch by Japin Li, per a suggestion from Tom Lane, with some changes to
the comments by me.  Review by Onder Kalaci, Alvaro Herrera, and me.

Discussion: https://postgr.es/m/18467-7bb89084ff03a08d%40postgresql.org

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b33c141cc52b5dfdf06dea1c36874a5842bada8f

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 21 +++++++++++++++++++++
contrib/postgres_fdw/postgres_fdw.c            | 14 ++++++++++++++
contrib/postgres_fdw/sql/postgres_fdw.sql      |  5 +++++
3 files changed, 40 insertions(+)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: meson: Restore implicit warning/debug/optimize flags for extensi
Next
From: Michael Paquier
Date:
Subject: pgsql: Add more debugging information when dropping twice pgstats entry