pgsql: Revise GUC names quoting in messages again - Mailing list pgsql-committers
| From | Peter Eisentraut |
|---|---|
| Subject | pgsql: Revise GUC names quoting in messages again |
| Date | |
| Msg-id | E1s7uEo-000c15-Dx@gemulon.postgresql.org Whole thread Raw |
| List | pgsql-committers |
Revise GUC names quoting in messages again After further review, we want to move in the direction of always quoting GUC names in error messages, rather than the previous (PG16) wildly mixed practice or the intermittent (mid-PG17) idea of doing this depending on how possibly confusing the GUC name is. This commit applies appropriate quotes to (almost?) all mentions of GUC names in error messages. It partially supersedes a243569bf65 and 8d9978a7176, which had moved things a bit in the opposite direction but which then were abandoned in a partial state. Author: Peter Smith <smithpb2250@gmail.com> Discussion: https://www.postgresql.org/message-id/flat/CAHut%2BPv-kSN8SkxSdoHano_wPubqcg5789ejhCDZAcLFceBR-w%40mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/17974ec259463869bb6bb4885d46847422fbc9ec Modified Files -------------- contrib/pg_prewarm/autoprewarm.c | 4 ++-- contrib/pg_stat_statements/pg_stat_statements.c | 6 ++--- contrib/sepgsql/hooks.c | 2 +- contrib/test_decoding/expected/slot.out | 2 +- doc/src/sgml/sources.sgml | 15 ++++--------- src/backend/access/gin/ginbulk.c | 2 +- src/backend/access/heap/vacuumlazy.c | 2 +- src/backend/access/table/tableamapi.c | 4 ++-- src/backend/access/transam/commit_ts.c | 4 ++-- src/backend/access/transam/multixact.c | 4 ++-- src/backend/access/transam/rmgr.c | 4 ++-- src/backend/access/transam/twophase.c | 6 ++--- src/backend/access/transam/xlog.c | 26 +++++++++++----------- src/backend/access/transam/xlogarchive.c | 2 +- src/backend/access/transam/xlogfuncs.c | 4 ++-- src/backend/access/transam/xlogprefetcher.c | 2 +- src/backend/access/transam/xlogrecovery.c | 12 +++++----- src/backend/commands/publicationcmds.c | 4 ++-- src/backend/commands/vacuum.c | 2 +- src/backend/commands/variable.c | 8 +++---- src/backend/libpq/be-secure-openssl.c | 4 ++-- src/backend/libpq/hba.c | 2 +- src/backend/libpq/pqcomm.c | 2 +- src/backend/parser/scan.l | 2 +- src/backend/port/sysv_sema.c | 2 +- src/backend/port/sysv_shmem.c | 8 +++---- src/backend/port/win32_shmem.c | 2 +- src/backend/postmaster/bgworker.c | 2 +- src/backend/postmaster/checkpointer.c | 2 +- src/backend/postmaster/pgarch.c | 10 ++++----- src/backend/postmaster/postmaster.c | 10 ++++----- src/backend/replication/logical/decode.c | 2 +- src/backend/replication/logical/launcher.c | 4 ++-- src/backend/replication/logical/logical.c | 4 ++-- src/backend/replication/logical/origin.c | 8 +++---- src/backend/replication/slot.c | 20 ++++++++--------- src/backend/replication/syncrep.c | 2 +- src/backend/storage/buffer/localbuf.c | 2 +- src/backend/storage/file/fd.c | 8 +++---- src/backend/storage/lmgr/lock.c | 12 +++++----- src/backend/storage/lmgr/predicate.c | 12 +++++----- src/backend/storage/lmgr/proc.c | 2 +- src/backend/tcop/postgres.c | 12 +++++----- src/backend/utils/adt/pg_locale.c | 4 ++-- src/backend/utils/adt/varlena.c | 2 +- src/backend/utils/fmgr/dfmgr.c | 4 ++-- src/backend/utils/misc/guc.c | 2 +- src/backend/utils/misc/guc_tables.c | 24 ++++++++++---------- src/bin/initdb/initdb.c | 4 ++-- src/bin/pg_basebackup/streamutil.c | 6 ++--- src/bin/pg_controldata/pg_controldata.c | 2 +- src/bin/pg_dump/pg_backup_archiver.c | 6 ++--- src/bin/pg_dump/pg_dump.c | 4 ++-- src/bin/pg_rewind/libpq_source.c | 4 ++-- src/bin/pg_rewind/pg_rewind.c | 6 ++--- src/bin/pg_test_fsync/pg_test_fsync.c | 2 +- src/bin/pg_upgrade/check.c | 6 ++--- src/bin/pg_upgrade/t/003_logical_slots.pl | 4 ++-- src/bin/pg_upgrade/t/004_subscription.pl | 2 +- src/bin/pgbench/pgbench.c | 2 +- src/fe_utils/archive.c | 2 +- src/interfaces/libpq/fe-auth.c | 2 +- src/interfaces/libpq/fe-connect.c | 4 ++-- .../commit_ts/expected/commit_timestamp_1.out | 12 +++++----- src/test/modules/libpq_pipeline/libpq_pipeline.c | 4 ++-- .../ssl_passphrase_callback/ssl_passphrase_func.c | 2 +- .../ssl_passphrase_callback/t/001_testfunc.pl | 2 +- src/test/modules/test_shm_mq/setup.c | 2 +- src/test/modules/test_slru/test_slru.c | 2 +- src/test/recovery/t/024_archive_recovery.pl | 4 ++-- .../recovery/t/035_standby_logical_decoding.pl | 2 +- src/test/regress/expected/collate.icu.utf8.out | 4 ++-- src/test/regress/expected/create_am.out | 2 +- src/test/regress/expected/json.out | 4 ++-- src/test/regress/expected/jsonb.out | 4 ++-- src/test/regress/expected/prepared_xacts_1.out | 18 +++++++-------- src/test/regress/expected/strings.out | 12 +++++----- src/test/ssl/t/001_ssltests.pl | 4 ++-- src/test/subscription/t/001_rep_changes.pl | 4 ++-- 79 files changed, 208 insertions(+), 215 deletions(-)
pgsql-committers by date: