pgsql: Disallow NO INHERIT not-null constraints on partitioned tables - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Disallow NO INHERIT not-null constraints on partitioned tables
Date
Msg-id E1s2SDY-0017p2-Io@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Disallow NO INHERIT not-null constraints on partitioned tables

Such constraints are semantically useless and only bring weird cases
along, so reject them.

As a side effect, we can no longer have "throwaway" constraints in
pg_dump for primary keys in partitioned tables, but since they don't
serve any useful purpose, we can just omit them.

Maybe this should be done for all types of constraints, but it's just
not-null ones that acquired this "ability" in the 17 timeframe, so for
the moment I'm not changing anything else.

Per note by Alexander Lakhin.
Discussion: https://postgr.es/m/7d923a66-55f0-3395-cd40-81c142b5448b@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/13daa33fa5a6d340f9be280db14e7b07ed11f92e

Modified Files
--------------
src/backend/parser/parse_utilcmd.c        | 10 ++++++++++
src/bin/pg_dump/pg_dump.c                 | 16 ++++++++++++++--
src/test/regress/expected/constraints.out |  5 +++++
src/test/regress/sql/constraints.sql      |  4 ++++
4 files changed, 33 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: doc: Fix incorrectly spelled structname
Next
From: Daniel Gustafsson
Date:
Subject: Re: pgsql: Fix compilation on OpenSSL 1.0.2 and LibreSSL