pgsql: xml2: Replace deprecated routines with recommended ones - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: xml2: Replace deprecated routines with recommended ones
Date
Msg-id E1rwZTl-002Go8-4g@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
xml2: Replace deprecated routines with recommended ones

Some functions are used in the tree and are currently marked as
deprecated by upstream.  This commit refreshes the code to use the
recommended functions, leading to the following changes:
- xmlSubstituteEntitiesDefault() is gone, and needs to be replaced with
XML_PARSE_NOENT for the paths doing the parsing.
- xmlParseMemory() -> xmlReadMemory().

These functions, as well as more functions setting global states, have
been officially marked as deprecated by upstream in August 2022.  Their
replacements exist since the 2001-ish area, as far as I have checked,
so that should be safe.

This has been originally applied as 65c5864d7fac without a backpatch,
and this has come up as well when working on 400928b83.  Per request
from Tom Lane, for new buildfarm member indri that is able to see
deprecation warnings with xmlSubstituteEntitiesDefault() in 16 and older
stable branches.

Author: Dmitry Koval
Discussion: https://postgr.es/m/18274-98d16bc03520665f@postgresql.org
Discussion: https://postgr.es/m/1012981.1713222862@sss.pgh.pa.us
Bakpatch-through: 12

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bb418aeee27078e2f3955a131515c151173143bd

Modified Files
--------------
contrib/xml2/xpath.c     | 14 ++++++++------
contrib/xml2/xslt_proc.c | 10 ++++++----
2 files changed, 14 insertions(+), 10 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Move code for backend startup to separate file
Next
From: David Rowley
Date:
Subject: pgsql: Improve test coverage in bump.c