pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket(). - Mailing list pgsql-committers

From Etsuro Fujita
Subject pgsql: Fix WaitEventSet resource leak in WaitLatchOrSocket().
Date
Msg-id E1rurQm-001a8j-TS@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix WaitEventSet resource leak in WaitLatchOrSocket().

This function would have the same issue we solved in commit 501cfd07d:
If an error is thrown after calling CreateWaitEventSet(), the file
descriptor (on epoll- or kqueue-based systems) or handles (on Windows)
that the WaitEventSet contains are leaked.

Like that commit, use PG_TRY-PG_FINALLY (PG_TRY-PG_CATCH in v12) to make
sure the WaitEventSet is freed properly.

Back-patch to all supported versions, but as we do not have this issue
in HEAD (cf. commit 50c67c201), no need to apply this patch to it.

Discussion: https://postgr.es/m/CAPmGK16MqdDoD8oatp8SQWaEa4vS3nfQqDN_Sj9YRuu5J3Lj9g%40mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/01b01a77fe786740ec5e657e5f2ed0a94ab0ac17

Modified Files
--------------
src/backend/storage/ipc/latch.c | 70 ++++++++++++++++++++++-------------------
1 file changed, 38 insertions(+), 32 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: [MASSMAIL]pgsql: Use correct datatype for xmin variables in slot.c
Next
From: Etsuro Fujita
Date:
Subject: pgsql: postgres_fdw: Improve comment about handling of asynchronous req