pgsql: Improve WIN32 waiting logic in psql's \watch command. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Improve WIN32 waiting logic in psql's \watch command.
Date
Msg-id E1ridhA-002k9t-9l@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve WIN32 waiting logic in psql's \watch command.

do_watch had some leftover logic for enabling siglongjmp out of
waiting for input.  That's never done anything on Windows (cf.
psql_cancel_callback), and do_watch no longer relies on it for
non-Windows, so let's drop it.

Also, when the user cancels \watch by pressing ^C, the Windows
code would run the query one more time before exiting.  That doesn't
seem very desirable, and it's not what happens on other platforms.
Use the "done" flag similarly to non-Windows to avoid the extra query
execution.

Yugo Nagata (with minor fixes by me)

Discussion: https://postgr.es/m/20240305220552.85fd4afd6b6b8103bf4fe3d0@sraoss.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f07a20c8a3b15e71d3cbfcfed0600956042cbe74

Modified Files
--------------
src/bin/psql/command.c | 27 ++++++++++-----------------
1 file changed, 10 insertions(+), 17 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Admit deferrable PKs into rd_pkindex, but flag them as such
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: Fix errorhandling for reading from a pipe