pgsql: Add recovery TAP test for race condition with slot invalidations - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Add recovery TAP test for race condition with slot invalidations
Date
Msg-id E1rhk4Q-002Lxw-9V@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add recovery TAP test for race condition with slot invalidations

This commit adds a recovery test to provide coverage for the bug fixed
in 818fefd8fd, using an injection point to wait just after the process
of an active slot is killed.  The trick is to give enough time for
effective_xmin and effective_catalog_xmin to advance so as the slot
invalidation robustness can be checked since the active process is
killed without holding its slot's mutex for a short time.

Author: Bertrand Drouvot
Discussion: https://postgr.es/m/ZdyZya4YrNapWKqz@ip-10-97-1-34.eu-west-3.compute.internal

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/08a52ab151ca599406883768cdc08b7929e516de

Modified Files
--------------
src/backend/replication/slot.c                     |   9 ++
.../recovery/t/035_standby_logical_decoding.pl     | 116 ++++++++++++++++++++-
2 files changed, 123 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Add --copy-file-range option to pg_upgrade.
Next
From: Amit Kapila
Date:
Subject: pgsql: Doc: Improve replication slot synchronization section.