pgsql: Fix overflow in Windows replacement pg_pread/pg_pwrite. - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Fix overflow in Windows replacement pg_pread/pg_pwrite.
Date
Msg-id E1rgVKB-001jv6-M2@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix overflow in Windows replacement pg_pread/pg_pwrite.

When calling the Windows file I/O APIs there is an implicit conversion
from size_t to DWORD, which could overflow.  Clamp the size at 1GB to
avoid that.

Not a really a live bug as we don't expect anything in PostgreSQL to
call with such large values.

Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://postgr.es/m/1672202.1703441340%40sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1e013746544bd1f9df70f5547894fd72719c4b85

Modified Files
--------------
src/port/win32pread.c  | 3 +++
src/port/win32pwrite.c | 3 +++
2 files changed, 6 insertions(+)


pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Return ssize_t in fd.c I/O functions.
Next
From: Jeff Davis
Date:
Subject: pgsql: Documentation update for Standard Collations.