pgsql: Remove AIX support - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Remove AIX support
Date
Msg-id E1rfI3i-001DYs-N4@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove AIX support

There isn't a lot of user demand for AIX support, we have a bunch of
hacks to work around AIX-specific compiler bugs and idiosyncrasies,
and no one has stepped up to the plate to properly maintain it.
Remove support for AIX to get rid of that maintenance overhead. It's
still supported for stable versions.

The acute issue that triggered this decision was that after commit
8af2565248, the AIX buildfarm members have been hitting this
assertion:

    TRAP: failed Assert("(uintptr_t) buffer == TYPEALIGN(PG_IO_ALIGN_SIZE, buffer)"), File: "md.c", Line: 472, PID:
2949728

Apperently the "pg_attribute_aligned(a)" attribute doesn't work on AIX
for values larger than PG_IO_ALIGN_SIZE, for a static const variable.
That could be worked around, but we decided to just drop the AIX support
instead.

Discussion: https://www.postgresql.org/message-id/20240224172345.32@rfd.leadboat.com
Reviewed-by: Andres Freund, Noah Misch, Thomas Munro

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0b16bb8776bb834eb1ef8204ca95dd7667ab948b

Modified Files
--------------
Makefile                                      |   2 +
config/c-compiler.m4                          |   2 +-
configure                                     | 331 +++-----------------------
configure.ac                                  |  68 +++---
doc/src/sgml/dfunc.sgml                       |  19 --
doc/src/sgml/installation.sgml                | 121 +---------
doc/src/sgml/runtime.sgml                     |  23 --
meson.build                                   |  60 +++--
src/Makefile.shlib                            |  29 ---
src/backend/Makefile                          |  20 --
src/backend/meson.build                       |  15 --
src/backend/port/aix/mkldexport.sh            |  61 -----
src/backend/utils/error/elog.c                |   2 -
src/backend/utils/misc/ps_status.c            |   4 +-
src/bin/pg_basebackup/t/010_pg_basebackup.pl  |   3 +-
src/bin/pg_verifybackup/t/008_untar.pl        |   3 +-
src/bin/pg_verifybackup/t/010_client_untar.pl |   3 +-
src/include/c.h                               |  18 +-
src/include/port/aix.h                        |  14 --
src/include/port/atomics.h                    |   6 +-
src/include/storage/s_lock.h                  |  31 +--
src/interfaces/libpq/Makefile                 |   2 +-
src/interfaces/libpq/meson.build              |   5 +-
src/makefiles/Makefile.aix                    |  39 ---
src/port/README                               |   2 +-
src/port/strerror.c                           |   2 -
src/template/aix                              |  25 --
src/test/regress/Makefile                     |   5 -
src/test/regress/expected/sanity_check.out    |  29 ---
src/test/regress/sql/sanity_check.sql         |  26 --
src/tools/gen_export.pl                       |  11 +-
src/tools/pginclude/cpluspluscheck            |   1 -
src/tools/pginclude/headerscheck              |   1 -
33 files changed, 116 insertions(+), 867 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Rename SLRU elements in view pg_stat_slru
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Run autoconf, for update of a comment.