pgsql: Revise pg_walsummary's 002_blocks test to avoid spurious failure - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Revise pg_walsummary's 002_blocks test to avoid spurious failure
Date
Msg-id E1rVCZy-0040l5-8L@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Revise pg_walsummary's 002_blocks test to avoid spurious failures.

Analysis of buildfarm results showed that the code that was intended
to wait for the inserts performed by this test to complete did not
actually do so. Try to make that logic more robust.

Improve error checking elsewhere in the script, too, so that we
don't miss things like poll_query_until failing.

Along the way, fix a bit of pgindent damage introduced by commit
5ddf9973477729cf161b4ad0a1efd52f4fea9c88, which aimed to help us
debug the failures that this commit is trying to fix. It's making
the buildfarm sad.

Discussion: http://postgr.es/m/CA+TgmobWFb8NqyfC31YnKAbZiXf9tLuwmyuvx=iYMXMniPQ4nw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ea18eb7d625573dc369df619f7ff3b9e60e47531

Modified Files
--------------
src/backend/backup/walsummary.c       |  2 +-
src/bin/pg_walsummary/t/002_blocks.pl | 47 +++++++++++++++++++++--------------
2 files changed, 29 insertions(+), 20 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: doc: Document more that relations share a namespace
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Update pg_walsummary copyright notices to 2024