pgsql: Abort pgbench if script end is reached with an open pipeline - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Abort pgbench if script end is reached with an open pipeline
Date
Msg-id E1rRxVN-002bsi-0b@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Abort pgbench if script end is reached with an open pipeline

When a pipeline is opened with \startpipeline and not closed, pgbench
will either error on the next transaction with a "already in pipeline
mode" error or successfully end if this was the last transaction --
despite not sending anything that was piped in the pipeline.

Make it an error to reach end of script is reached while there's an
open pipeline.

Backpatch to 14, where pgbench got support for pipelines.

Author: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Reported-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/Za4IObZkDjrO4TcS@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/49f7c6c44a5f6a7f7b39d140e490c9c627511893

Modified Files
--------------
src/bin/pgbench/pgbench.c                    | 15 +++++++++++++--
src/bin/pgbench/t/001_pgbench_with_server.pl | 28 ++++++++++++++++++++++++++++
2 files changed, 41 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Test EXPLAIN (FORMAT JSON) ... XMLTABLE
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix two memcpy() bugs in the new injection point code