pgsql: Handle WindowClause.runCondition in tree walker/mutator function - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Handle WindowClause.runCondition in tree walker/mutator function
Date
Msg-id E1rNdRe-000nzr-TN@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Handle WindowClause.runCondition in tree walker/mutator functions.

Commit 9d9c02ccd, which added the notion of a "run condition" for
window functions, neglected to teach nodeFuncs.c to process the new
field.  Remarkably, that doesn't seem to have had any ill effects
before we invented Var.varnullingrels, but now it can cause visible
failures in join-removal scenarios.

I have no faith that there's not reachable problems in v15 too,
so back-patch the code change to v15 where 9d9c02ccd came in.
The test case seems irrelevant to v15, though.

Per bug #18277 from Zuming Jiang.  Diagnosis and patch by
Richard Guo.

Discussion: https://postgr.es/m/18277-089ead83b329a2fd@postgresql.org

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c3f52fd5d7160733e6b78fc8957e8990a3341bda

Modified Files
--------------
src/backend/nodes/nodeFuncs.c | 6 ++++++
1 file changed, 6 insertions(+)


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: doc: clarify who owns the initdb-created cluster, by default
Next
From: Tom Lane
Date:
Subject: pgsql: Fix Asserts in calc_non_nestloop_required_outer().