pgsql: Additional write barrier in AdvanceXLInsertBuffer(). - Mailing list pgsql-committers

From Jeff Davis
Subject pgsql: Additional write barrier in AdvanceXLInsertBuffer().
Date
Msg-id E1rFldM-00B0Kl-K5@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Additional write barrier in AdvanceXLInsertBuffer().

First, mark the xlblocks member with InvalidXLogRecPtr, then issue a
write barrier, then initialize it. That ensures that the xlblocks
member doesn't appear valid while the contents are being initialized.

In preparation for reading WAL buffer contents without a lock.

Author: Bharath Rupireddy
Discussion: https://postgr.es/m/CALj2ACVfFMfqD5oLzZSQQZWfXiJqd-NdX0_317veP6FuB31QWA@mail.gmail.com
Reviewed-by: Andres Freund

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/766571be16598b401b5527208847145edc6be1f4

Modified Files
--------------
src/backend/access/transam/xlog.c | 8 ++++++++
1 file changed, 8 insertions(+)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix generation of distribution tarball