pgsql: Prevent tuples to be marked as dead in subtransactions on standb - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Prevent tuples to be marked as dead in subtransactions on standb
Date
Msg-id E1rD5HX-009rzC-97@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Prevent tuples to be marked as dead in subtransactions on standbys

Dead tuples are ignored and are not marked as dead during recovery, as
it can lead to MVCC issues on a standby because its xmin may not match
with the primary.  This information is tracked by a field called
"xactStartedInRecovery" in the transaction state data, switched on when
starting a transaction in recovery.

Unfortunately, this information was not correctly tracked when starting
a subtransaction, because the transaction state used for the
subtransaction did not update "xactStartedInRecovery" based on the state
of its parent.  This would cause index scans done in subtransactions to
return inconsistent data, depending on how the xmin of the primary
and/or the standby evolved.

This is broken since the introduction of hot standby in efc16ea52067, so
backpatch all the way down.

Author: Fei Changhong
Reviewed-by: Kyotaro Horiguchi
Discussion: https://postgr.es/m/tencent_C4D907A5093C071A029712E73B43C6512706@qq.com
Backpatch-through: 12

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8a7cbfce13d476a3e9782111c45a7b3335646ee4

Modified Files
--------------
src/backend/access/transam/xact.c | 1 +
1 file changed, 1 insertion(+)


pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: Fix typo in comment
Next
From: Daniel Gustafsson
Date:
Subject: pgsql: docs: Fix typo in pg_stat_statements documentation