pgsql: Fix a random failure in 003_logical_slots.pl. - Mailing list pgsql-committers

From Amit Kapila
Subject pgsql: Fix a random failure in 003_logical_slots.pl.
Date
Msg-id E1rAMTO-008eHP-Fg@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix a random failure in 003_logical_slots.pl.

The failed test was trying to validate that the two_phase option for a
slot is retained after the upgrade. The problem was that it didn't get
enabled before the upgrade so expecting to be enabled after the upgrade
was not right in the first place. This is a timing issue because we enable
the two_phase once the initial sync for all the tables is finished.
Normally, we wait for the two_phase state to be enabled but this test
missed that step.

Per buildfarm.

Author: Hayato Kuroda
Discussion: https://postgr.es/m/TY3PR01MB98892396D1071FC4320D6B31F586A@TY3PR01MB9889.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/63c5df126abb7364b70dafe75fef576dd8eb0bbc

Modified Files
--------------
src/bin/pg_upgrade/t/003_logical_slots.pl | 6 ++++++
1 file changed, 6 insertions(+)


pgsql-committers by date:

Previous
From: Jeff Davis
Date:
Subject: pgsql: Optimize SearchPathCache by saving the last entry.
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Fix handling of errors in libpq pipelines