pgsql: Avoid overflow in fe_utils' printTable() - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Avoid overflow in fe_utils' printTable()
Date
Msg-id E1r5RJF-006Wty-2W@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid overflow in fe_utils' printTable()

The original code would miscalculate the total number of cells when the
table to print has more than ~4 billion cells, leading to an unnecessary
error.  Repair by changing some computations to be 64-bits wide.  Add
some necessary overflow checks.

Author: Hongxu Ma <interma@outlook.com>
Discussion: https://postgr.es/m/TYBP286MB0351B057B101C90D7C1239E6B4E2A@TYBP286MB0351.JPNP286.PROD.OUTLOOK.COM

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/24ea53dcfab7fe463c0cf56095e9fe5d23cdb748

Modified Files
--------------
src/fe_utils/print.c         | 30 ++++++++++++++++++++++--------
src/include/fe_utils/print.h |  2 +-
2 files changed, 23 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Simplify some logic in CreateReplicationSlot()
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Remove unneeded assignments in for loop header